[dpdk-dev] [PATCH 2/3] eal: add synchronous multi-process communication
konstantin.ananyev at intel.com
Mon Dec 11 17:49:18 CET 2017
> > @@ -485,7 +508,8 @@ rte_eal_mp_sendmsg(const char *action_name,
> > const void *params,
> > int len_params,
> > int fds,
> > - int fds_num)
> > + int fds_num,
> > + int need_ack)
> I think "need_ack" is a misnomer because what we really want is not
> "ack" but a response.
> More importantly, i think for clarity's sake, this should be a separate
> function - something like rte_eal_mp_sendreq() or maybe a better name
> (reqdata? communicate?).
+1 for a separate function.
Also I don't think it should disturb/block mp_handler() - there could be messages
for other actions (from other endpoints).
I think only rte_eal_mp_sendreq() should be blocked till ack/response is received.
And probably it needs max timeout to block for.
More information about the dev