[dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver
stephen at networkplumber.org
Mon Dec 18 22:17:51 CET 2017
On Mon, 18 Dec 2017 20:54:16 +0100
Thomas Monjalon <thomas at monjalon.net> wrote:
> > > +#endif /* RTE_LIBRTE_HYPERV_DEBUG */
> > > +
> > > +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__)
> > > +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__)
> > > +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__)
> > > +#define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__)
> > > +
> > Please don't use DEBUG() etc macros. It makes it easier for tools that do
> > global updates or scans if all drivers use the same model of PMD_DRV_LOG
> The new standard is to use dynamic logtype.
Agree, please use dynamic logging, and also don't redefine new macros like DEBUG/INFO/WARN/ERROR.
Instead use PMD_DRV_LOG or equivalent macros.
The base rule here is that all drivers should look the same as much
as reasonably possible. This makes reviewers of other subsystems more likely
to see problems. It also allows for later changes where some developer does a global
improvement across many PMD's.
Drivers should not be snowflakes, each one is not unique.
More information about the dev