[dpdk-dev] [PATCH 3/3] doc: remove ABI changes in igb_uio

Tan, Jianfeng jianfeng.tan at intel.com
Wed Feb 1 08:24:18 CET 2017



On 1/31/2017 1:52 AM, Thomas Monjalon wrote:
> 2017-01-24 13:35, Ferruh Yigit:
>> On 1/24/2017 7:34 AM, Jianfeng Tan wrote:
>>> We announced ABI changes to remove iomem and ioport mapping in
>>> igb_uio. But it has potential backward compatibility issue: cannot
>>> run old version DPDK on modified igb_uio.
>>>
>>> The purpose of this changes was to fix a bug: when DPDK app crashes,
>>> those devices by igb_uio are not stopped either DPDK PMD driver or
>>> igb_uio driver. We need to figure out new way to fix this bug.
>> Hi Jianfeng,
>>
>> I believe it would be good to fix this potential defect.
>>
>> Is "remove iomem and ioport" a must for that fix? If so, I suggest
>> re-think about it.
>>
>> If I see correctly, dpdk1.8 and older uses igb_uio iomem files. So
>> backward compatibility is the possible issue for dpdk1.8 and older.
>> Since v1.8 two years old, I would prefer fixing defect instead of
>> keeping that backward compatibility.
>>
>> Jianfeng, Thomas,
>>
>> What do you think postponing this deprecation notice to next release,
>> instead of removing it, and discuss more?
>>
>>
>> And overall, if "remove iomem and ioport" is not a must for this fix, no
>> problem to remove deprecation notice.
> I have no strong opinion here.
> Jianfeng, do you agree with Ferruh?

Hi Ferruh & Thomas,

I agree wit Ferruh to postpone this deprecation notice.

In another thread, we discussed the possibility to fix this problem 
without the deprecation. But I have no time to verify it in this release 
cycle. Let's postpone it then.

Thanks,
Jianfeng


More information about the dev mailing list