[dpdk-dev] [PATCH] net/tap: fix coverity warning on strncpy

Wiles, Keith keith.wiles at intel.com
Fri Feb 17 15:48:51 CET 2017


> On Feb 17, 2017, at 8:44 AM, Keith Wiles <keith.wiles at intel.com> wrote:
> 
> Calling strncpy with a maximum size argument of 16 bytes on destination
> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the
> destination string unterminated.
> 
> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index efc4426..f9938d7 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short flags, int add)
> 		return -1;
> 	}
> 	memset(&ifr, 0, sizeof(ifr));
> -	strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ);
> +	strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ-1);
> 	err = ioctl(s, SIOCGIFFLAGS, &ifr);
> 	if (err < 0) {
> 		RTE_LOG(WARNING, PMD, "Unable to get %s device flags: %s\n”,

NAK missed the spaces around ‘-‘ :-(

> -- 
> 2.8.0.GIT
> 

Regards,
Keith



More information about the dev mailing list