[dpdk-dev] [PATCH v5 08/26] eal: do not panic on memzone initialization fails

[Bruce Richardson]

On Mon, Feb 27, 2017 at 11:17:53AM -0500, Aaron Conole wrote:
> When memzone initialization fails, report the error to the calling
> application rather than panic().  Without a good way of detaching /
> releasing hugepages, at this point the application will have to restart.
> 
> Signed-off-by: Aaron Conole <aconole at redhat.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index a671ed4..1e54ca1 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -839,8 +839,11 @@ rte_eal_init(int argc, char **argv)
>  	/* the directories are locked during eal_hugepage_info_init */
>  	eal_hugedirs_unlock();
>  
> -	if (rte_eal_memzone_init() < 0)
> -		rte_panic("Cannot init memzone\n");
> +	if (rte_eal_memzone_init() < 0) {
> +		RTE_LOG(ERR, EAL, "Cannot init memzone\n");

Any particular reason why not "rte_eal_init_alert" as with the other
cases?

/Bruce