[dpdk-dev] [PATCH 1/2] ethdev: fix name index in xstats Api

Remy Horton remy.horton at intel.com
Tue Jan 3 11:03:52 CET 2017


Been away, hence the somewhat late review..

On 16/12/2016 09:44, Olivier Matz wrote:
[..]
> Today, each 'id' returned by rte_eth_xstats_get() is equal to the index
> in the returned array, making this value useless. It also prevents a
> driver from having different indexes for names and value, like in the
> example below:

My original intention was to give free reign over what id numbers are 
used, but for reasons I've now forgotten the implementation ended up 
making everything sequential.

> CC: stable at dpdk.org
> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids")
>
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>

Acked-by: Remy Horton <remy.horton at intel.com>


More information about the dev mailing list