[dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close

Wu, Jingjing jingjing.wu at intel.com
Fri Jan 6 02:29:11 CET 2017



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Tuesday, January 3, 2017 2:55 PM
> To: dev at dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger at intel.com>; stable at dpdk.org
> Subject: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close
> 
> From: Bernard Iremonger <bernard.iremonger at intel.com>
> 
> The vsi's have already been released, so the second call to i40e_vsi_release
> results in a segmentation fault.
> The second call to i40e_vsi_release has been removed.
Where is the first call to release vmdq vsi?

Thanks
Jingjing
> 
> Fixes: 3cb446b4aeb2 ("i40e: free vmdq vsi when closing")
> 
> CC: stable at dpdk.org
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index be45cfa..0b7c366 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -1882,7 +1882,6 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw
> *hw)
>  	i40e_vsi_release(pf->main_vsi);
> 
>  	for (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) {
> -		i40e_vsi_release(pf->vmdq[i].vsi);
>  		pf->vmdq[i].vsi = NULL;
>  	}
> 
> @@ -4137,6 +4136,9 @@ enum i40e_status_code
>  	if (!vsi)
>  		return I40E_SUCCESS;
> 
> +	if (!vsi->adapter)
> +		return I40E_ERR_BAD_PTR;
> +
>  	user_param = vsi->user_param;
> 
>  	pf = I40E_VSI_TO_PF(vsi);
> --
> 1.9.3



More information about the dev mailing list