[dpdk-dev] [PATCH v7 18/27] app/testpmd: use VFD APIs on i40e

[Lu, Wenzhuo]

Hi Jingjing,


> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, January 6, 2017 9:16 AM
> To: Lu, Wenzhuo; dev at dpdk.org
> Cc: Lu, Wenzhuo; Chen, Jing D; Iremonger, Bernard
> Subject: RE: [dpdk-dev] [PATCH v7 18/27] app/testpmd: use VFD APIs on i40e
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Tuesday, January 3, 2017 2:55 PM
> > To: dev at dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Chen, Jing D
> > <jing.d.chen at intel.com>; Iremonger, Bernard
> > <bernard.iremonger at intel.com>
> > Subject: [dpdk-dev] [PATCH v7 18/27] app/testpmd: use VFD APIs on i40e
> >
> > The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd
> > code to use them, including VF MAC anti-spoofing, VF VLAN
> > anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen at intel.com>
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> > ---
> >  app/test-pmd/Makefile  |   3 +
> >  app/test-pmd/cmdline.c | 154
> +++++++++++++++++++++++++++++++++++++++-
> > ---------
> >  2 files changed, 126 insertions(+), 31 deletions(-)
> >
> > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index
> > 891b85a..66bd38a 100644
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -58,7 +58,10 @@ SRCS-y += csumonly.c  SRCS-y += icmpecho.c
> >  SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c
> >
> > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += -lrte_pmd_i40e endif
> >
> >  CFLAGS_cmdline.o := -D_GNU_SOURCE
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > ed84d7a..9a44b4f 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -90,6 +90,9 @@
> >  #ifdef RTE_LIBRTE_IXGBE_PMD
> >  #include <rte_pmd_ixgbe.h>
> >  #endif
> > +#ifdef RTE_LIBRTE_I40E_PMD
> > +#include <rte_pmd_i40e.h>
> > +#endif
> >  #include "testpmd.h"
> >
> >  static struct cmdline *testpmd_cl;
> > @@ -262,19 +265,19 @@ static void cmd_help_long_parsed(void
> > *parsed_result,
> >  			"set portlist (x[,y]*)\n"
> >  			"    Set the list of forwarding ports.\n\n"
> >
> > -#ifdef RTE_LIBRTE_IXGBE_PMD
> 
> How about use
> #if defined(RTE_LIBRTE_IXGBE_PMD) || defined (RTE_LIBRTE_I40E_PMD) but
> not remove it, because this command only works for ixgbe and i40e pmd.
It's on purpose. Just like regular CLIs, we show them no matter NIC supports it or not. We will check when processing CLIs.

> 
> >  			"set tx loopback (port_id) (on|off)\n"
> >  			"    Enable or disable tx loopback.\n\n"
> >
> > +#ifdef RTE_LIBRTE_IXGBE_PMD
> >  			"set all queues drop (port_id) (on|off)\n"
> >  			"    Set drop enable bit for all queues.\n\n"
> >
> >  			"set vf split drop (port_id) (vf_id) (on|off)\n"
> >  			"    Set split drop enable bit for a VF from the PF.\n\n"
> > +#endif
> >
> >  			"set vf mac antispoof (port_id) (vf_id) (on|off).\n"
> >  			"    Set MAC antispoof for a VF from the PF.\n\n"
> > -#endif
> >