[dpdk-dev] [PATCH 3/7] bnx2x: remove useless return's

Stephen Hemminger stephen at networkplumber.org
Tue Jan 10 00:30:18 CET 2017


Don't need empty return; at end of void function.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/bnx2x/bnx2x.c        | 2 --
 drivers/net/bnx2x/bnx2x_ethdev.c | 2 --
 drivers/net/bnx2x/elink.c        | 1 -
 3 files changed, 5 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 28566302..38068f6b 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -1371,8 +1371,6 @@ static void bnx2x_drain_tx_queues(struct bnx2x_softc *sc)
 			rmb();
 		}
 	}
-
-	return;
 }
 
 static int
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 7140118f..1d38c4bf 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -225,8 +225,6 @@ bnx2x_dev_stop(struct rte_eth_dev *dev)
 		PMD_DRV_LOG(DEBUG, "bnx2x_nic_unload failed (%d)", ret);
 		return;
 	}
-
-	return;
 }
 
 static void
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 53293962..287869d5 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -10362,7 +10362,6 @@ static void elink_5461x_set_link_led(struct elink_phy *phy,
 	elink_cl22_write(sc, phy,
 			 MDIO_REG_GPHY_SHADOW,
 			 MDIO_REG_GPHY_SHADOW_WR_ENA | temp);
-	return;
 }
 
 static void elink_54618se_link_reset(struct elink_phy *phy,
-- 
2.11.0



More information about the dev mailing list