[dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device pointer in cryptodevice

Akhil Goyal akhil.goyal at nxp.com
Thu Jan 12 13:26:45 CET 2017


On 1/9/2017 7:04 PM, De Lara Guarch, Pablo wrote:
> Hi,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Akhil Goyal
>> Sent: Thursday, December 22, 2016 8:17 PM
>> To: dev at dpdk.org
>> Cc: thomas.monjalon at 6wind.com; Doherty, Declan; De Lara Guarch, Pablo;
>> hemant.agrawal at nxp.com; Mcnamara, John; nhorman at tuxdriver.com;
>> Akhil Goyal
>> Subject: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device
>> pointer in cryptodevice
>>
>> This patch will not be required as some parallel work is going
>> on to add it across all crypto devices.
>>
> Could you tell me the patch that is going to add this?
> In that case, you can drop this and just say that your patchset depends on it.
>
> Also, the title should be "cryptodev: add rte_device pointer in crypto device".
> Note that for libraries, you just need the name of the library (i.e. cryptodev).
> The other thing is that the first letter should be lowercase. Could you change this in the other patches too?
>
>
> Thanks,
> Pablo
>
Thanks for your comments Pablo.

There is some discussion ongoing regarding bus model for DPAA2 platform. 
This change is already there for ethdev and we would be replicating the 
same for cryptodev, once the bus model patches are completed. This is 
added here so that compilation is not broken for subsequent patches.

For title, I will correct that in next version.

Thanks,
Akhil



More information about the dev mailing list