[dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
Tan, Jianfeng
jianfeng.tan at intel.com
Wed Jan 18 14:49:29 CET 2017
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 18, 2017 7:53 PM
> To: Tan, Jianfeng; dev at dpdk.org
> Cc: Liu, Yuanhan; stable at dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>
> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> > API rte_eth_dev_info_get() fills driver name according to drv_name
> > of rte_eth_dev_data. But we have not fill such info in virtio_user.
> >
> > We do not use the same one with virtio device as some applications
> > might depend on driver name to differetiate kinds of devices, such
> > as VPP.
> >
> > Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> > CC: stable at dpdk.org
> >
> > Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com>
> > ---
> > drivers/net/virtio/virtio_user_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> > index c877968..110f6a9 100644
> > --- a/drivers/net/virtio/virtio_user_ethdev.c
> > +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> > hw->use_simple_rxtx = 0;
> > hw->virtio_user_dev = dev;
> > data->dev_private = hw;
> > + data->drv_name = "virtio_user PMD";
>
> How driver naming done changed in next-net.
> Please check any other virtual driver in next-net for sample.
Thank you for the info. And it seems that it's already fixed by that patch.
Self NACK.
Thanks,
Jianfeng
>
> > data->numa_node = SOCKET_ID_ANY;
> > data->kdrv = RTE_KDRV_NONE;
> > data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> >
More information about the dev
mailing list