[dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

[Ananyev, Konstantin]

Hi Jingjng,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jingjing Wu
> Sent: Tuesday, January 24, 2017 11:48 AM
> To: dev at dpdk.org
> Cc: Wu, Jingjing <jingjing.wu at intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags
> 
> Some Tx offload flags are missed in Bitmask of all supported packet
> Tx offload features flags.
> This patch fixes it.

Not sure what it exactly fixes?
As I remember these flags don't specify any TX offload for HW to perform,
But just provide information to the TX function.
Again, why only i40e code is modified?
As I remember we have the same code in other PMDs too.
Konstantin

> 
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Signed-off-by: Jingjing Wu <jingjing.wu at intel.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index bfce9f4..e57a4d2 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -295,8 +295,12 @@ extern "C" {
>   */
>  #define PKT_TX_OFFLOAD_MASK (    \
>  		PKT_TX_IP_CKSUM |        \
> +		PKT_TX_IPV4 |            \
> +		PKT_TX_IPV6 |            \
>  		PKT_TX_L4_MASK |         \
>  		PKT_TX_OUTER_IP_CKSUM |  \
> +		PKT_TX_OUTER_IPV4 |      \
> +		PKT_TX_OUTER_IPV6 |      \
>  		PKT_TX_TCP_SEG |         \
>  		PKT_TX_QINQ_PKT |        \
>  		PKT_TX_VLAN_PKT |        \
> --
> 2.4.11