[dpdk-dev] [PATCH v5] net/bond: fixes for link properties management

[Ferruh Yigit]

On 7/5/2017 6:09 PM, Declan Doherty wrote:
> From: Tomasz Kulasek <tomaszx.kulasek at intel.com>
> 
> This patch fixes the management of link properties in the bonded device.
> 
> In all mode except mode 4 a bonded device link will default to reporting
> the link as full duplex and auto-neg. The link speed for a bond port is
> calculated on it's active slaves and the particular mode it is running
> in. The bonding link speed is reported based on the transmit link as in
> some modes link speed between egress/ingress is not symmetrical.
> 
> - round-robin, balance, 802.3ad, TLB and ALB modes all report the link
>   speed as the sum of the speed of each active slave.
> - active backup link speed is reported as the speed of the current
>   primary slave
> - broadcast is reported as the minimum of value of the active slaves
>   link speeds.
> 
> In mode 4 (link aggregation 802.3ad) the properties of the first slave
> added to the bonded device are slave and subsequent slaves are verified
> to have the same properties.
> 
> Finally in the bond_ethdev_lsc_event_callback function the link
> properties of the device are updated after any change to the number of
> active slaves.
> 
> Signed-off-by: Declan Doherty <declan.doherty at intel.com>

Gcc is throwing another warning [1].

And can you please send next version as full patchset, for the sake of
the traceability of merged patches in the future.


[1]
.../dpdk/drivers/net/bonding/rte_eth_bond_pmd.c: In function
‘bond_ethdev_lsc_event_callback’:
.../dpdk/drivers/net/bonding/rte_eth_bond_pmd.c:2472:39: error: variable
‘slave_eth_dev’ set but not used [-Werror=unused-but-set-variable]
  struct rte_eth_dev *bonded_eth_dev, *slave_eth_dev;
                                       ^~~~~~~~~~~~~