[dpdk-dev] [PATCH 0/9] fix hotplug API

[Jan Blunck]

On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet <gaetan.rivet at 6wind.com> wrote:
> Sending those fixes as separate patches as they stand on their own.
> This series improves usability of the hotplug API and fixes a few issues
> with existing implementations.
>

Interesting that you send this series as fixes. From what I can tell
this is a collection of changes that you have proposed before and I
have commented on and requested changes for. But I don't see that they
have been addressed at all:

- you still concatenate the bus and device name just to pass it down
to the buses and parse it into its components again
- you still delegate the devargs parsing to the buses

Please fix this issues. If you really want to return a device handle
from the hotplug API please present the use-case and in which cases
this solves a real-world problem.


> The hotplug API can be tested with the fail-safe PMD[1]. Its
> documentation describes how to declare slaves and how to use it.
>
> [1]: http://dpdk.org/ml/archives/dev/2017-July/070529.html
>
> Gaetan Rivet (9):
>   eal: return device handle upon plugin
>   eal: fix hotplug add
>   devargs: introduce removal function
>   eal: release devargs on device removal
>   pci: use given name as generic name
>   pci: fix generic driver pointer on probe error
>   pci: fix hotplug operations
>   vdev: implement plug operation
>   bus: remove useless plug parameter
>
>  lib/librte_eal/bsdapp/eal/eal_pci.c             |  4 +-
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map   |  1 +
>  lib/librte_eal/common/eal_common_dev.c          | 83 +++++++++++++++++++++----
>  lib/librte_eal/common/eal_common_devargs.c      | 18 ++++++
>  lib/librte_eal/common/eal_common_pci.c          | 49 +++++++--------
>  lib/librte_eal/common/eal_common_vdev.c         | 12 ++--
>  lib/librte_eal/common/eal_private.h             |  5 ++
>  lib/librte_eal/common/include/rte_bus.h         |  6 +-
>  lib/librte_eal/common/include/rte_dev.h         | 10 +--
>  lib/librte_eal/common/include/rte_devargs.h     | 18 ++++++
>  lib/librte_eal/common/include/rte_vdev.h        |  7 +++
>  lib/librte_eal/linuxapp/eal/eal_pci.c           |  4 +-
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map |  1 +
>  13 files changed, 162 insertions(+), 56 deletions(-)
>
> --
> 2.1.4
>