[dpdk-dev] [PATCH] net/i40e: fix link down and negotiation issue

Guo, Jia jia.guo at intel.com
Fri Jul 21 04:56:18 CEST 2017


Yes, I have already use cpu_to_le32 to translator, but I agree first defend it as uint32_t might be better to read . I will send v2 , thanks for review.

Best regards,
Jeff Guo


-----Original Message-----
From: Wu, Jingjing 
Sent: Friday, July 21, 2017 10:26 AM
To: Guo, Jia <jia.guo at intel.com>; Xing, Beilei <beilei.xing at intel.com>
Cc: dev at dpdk.org
Subject: RE: [PATCH] net/i40e: fix link down and negotiation issue



> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, July 20, 2017 4:45 PM
> To: Xing, Beilei <beilei.xing at intel.com>; Wu, Jingjing 
> <jingjing.wu at intel.com>
> Cc: dev at dpdk.org; Guo, Jia <jia.guo at intel.com>
> Subject: [PATCH] net/i40e: fix link down and negotiation issue
> 
> Enable the functions set link down and set link up in i40e by check 
> phy_type, and fix the issue of auto negotiation failed in XXV710 when 
> bind kernel driver after unbind from dpdk driver by modify the speed 
> setting distinguish from set link up and down. With this fix, if 
> unbind dpdk to bind kernel driver, no need to set auto negotiation and ifconfi up anymore, remove the part from doc.
> 
> Fixes: ca7e599d4506 ("net/i40e: fix link management")
> Fixes: 2f1e22817420 ("i40e: skip link control as firmware workaround")
> Fixes: 6e145fcc754b ("6e145fcc754b5e79167")

What is this? Need to add title.

How about to CC stable at dpdk.org?


>  	enum i40e_status_code status;
>  	struct i40e_aq_get_phy_abilities_resp phy_ab;
>  	struct i40e_aq_set_phy_config phy_conf;
> +	enum i40e_aq_phy_type cnt;
> +	__le32 phy_type_mask = 0;

Please define it as unit32_t, and use cpu_to_le32 when assigning,





More information about the dev mailing list