[dpdk-dev] [RFC] Add Membership Library

[Vincent Jardin]

Le 1 juin 2017 03:03:39 "Wang, Yipeng1" <yipeng1.wang at intel.com> a écrit :

> Hi Vincent,
>
> Thanks for the comments and some quick responses below:
>
> - DPDK Bloom Filter is derived from the libbloom (as shown by the included 
> BSD license), but optimized for performance with various DPDK goodness such 
> as rte_zmalloc, rte_bitmap, rte_jhash, etc. It doesn't seem appropriate to  
>   bring those DPDK specific features into libbloom, which is designed for 
> more generic environments.

Did you try and ask to the original author?

> - DPDK Bloom Filter is just one very basic mode among other more 
> sophisticated ones in the DPDK Membership Library, which supports a 
> different set of APIs (e.g., bulk lookup, multi-match, etc.) than those 
> supported in libbloom.

How does it justify forking the code?

> - It may make sense to bring some generic (i.e., non DPDK specific) 
> improvements back to libbloom once identified.

So let's start first with contributions to libbloom, please.


>
> Thanks
> Yipeng
>
>> -----Original Message-----
>> From: Vincent Jardin [mailto:vincent.jardin at 6wind.com]
>> Sent: Saturday, May 27, 2017 2:42 AM
>> To: Wang, Yipeng1 <yipeng1.wang at intel.com>
>> Cc: dev at dpdk.org; Gobriel, Sameh <sameh.gobriel at intel.com>; Wang, Ren
>> <ren.wang at intel.com>; Tai, Charlie <charlie.tai at intel.com>
>> Subject: Re: [dpdk-dev] [RFC] Add Membership Library
>>
>> Why duplicating Jyri's libbloom - https://github.com/jvirkki/libbloom - for 
>> this
>> DPDK capability? Why not showing that you can contribute to libbloom and
>> make it linkable with the DPDK?
>>
>> There are so many duplicated code...
>>
>> Thank you,
>>   Vincent
>>
>