[dpdk-dev] [PATCH v2 06/11] net/e1000: parse ethertype filter

[Zhao1, Wei]

Hi， Wenzhuo

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Monday, June 5, 2017 11:14 AM
> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> Subject: RE: [PATCH v2 06/11] net/e1000: parse ethertype filter
> 
> Hi Wei,
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, June 2, 2017 2:36 PM
> > To: dev at dpdk.org
> > Cc: Lu, Wenzhuo; Zhao1, Wei
> > Subject: [PATCH v2 06/11] net/e1000: parse ethertype filter
> >
> > check if the rule is a ethertype rule, and get the ethertype info.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> > ---
> >  drivers/net/e1000/igb_flow.c | 280
> > +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 280 insertions(+)
> 
> > +
> > +	/* The first non-void item should be MAC. */
> > +	item = pattern + index;
> > +	while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {
> > +		index++;
> > +		item = pattern + index;
> > +	}
> You've created a macro to do it in the previous patch, why not use the macro?
> The same below.

Yes, maybe I should use NEXT_ITEM_OF_PATTERN(item, pattern, index)  to replace it in v3.