[dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending

[Bruce Richardson]

On Wed, Jun 07, 2017 at 01:20:45PM +0000, De Lara Guarch, Pablo wrote:
> Hi Jingjing,
> 
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Wednesday, June 07, 2017 10:18 AM
> > To: De Lara Guarch, Pablo
> > Cc: dev at dpdk.org
> > Subject: RE: [PATCH] app/testpmd: add parameter to start forwarding
> > sending
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: De Lara Guarch, Pablo
> > > Sent: Monday, May 29, 2017 5:37 AM
> > > To: Wu, Jingjing <jingjing.wu at intel.com>
> > > Cc: dev at dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch at intel.com>
> > > Subject: [PATCH] app/testpmd: add parameter to start forwarding
> > sending
> > >
> > > Add parameter to start forwarding sending first
> > > a burst of packets, which is useful when testing
> > > a loopback connection.
> > >
> > > This was already implemented as an internal command,
> > > but adding it as a parameter is interesting, as it
> > > allows the user to test a loopback connection without
> > > entering in the internal command line.
> > >
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > > ---
> > >  app/test-pmd/parameters.c             | 5 +++++
> > >  app/test-pmd/testpmd.c                | 5 +++--
> > >  app/test-pmd/testpmd.h                | 1 +
> > >  doc/guides/testpmd_app_ug/run_app.rst | 4 ++++
> > >  4 files changed, 13 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > > index fbe6284..0da4172 100644
> > > --- a/app/test-pmd/parameters.c
> > > +++ b/app/test-pmd/parameters.c
> > > @@ -89,6 +89,7 @@ usage(char* progname)
> > >  	       "[--cmdline-file=FILENAME] "
> > >  #endif
> > >  	       "[--help|-h] | [--auto-start|-a] | ["
> > > +	       "--tx-first"
> > 
> > Just consider about the interactive mode.
> > If using command start, will it still call start_packet_forwarding(0)?
> > And if start tx_first, still call start_packet_forwarding(1)?
> > 
> 
> If using the commands "start" and "start tx_first", the behaviour will remain the same.
> The only behaviour that will change is the non-interactive forwarding mode,
> and when using auto-start in interactive mode.
> 
> Do you think it should modify the behaviour of "start", in the command line,
> so if "--tx-first" is passed, then it sends a burst regardless using "start" or "start tx_first"?
> 
> Thanks for the review!
> Pablo
> 
> > It may cause confused whether this argu "--tx-first" works.
> > If it only works for non-interactive, you'd better to comment it.
> > 
> > 
My 2c is that this flag should be only used for non-interactive mode,
and you get an error if it is used with -i flag. That should minimize any
confusion.

/Bruce