[dpdk-dev] [PATCH 1/2] test/test_mbuf: Remove mempool global var
santosh.shukla at caviumnetworks.com
Thu Jun 8 13:21:53 CEST 2017
On Thursday 08 June 2017 03:38 PM, Olivier Matz wrote:
> Hi Santosh,
> On Thu, 11 May 2017 16:00:43 +0530, Santosh Shukla <santosh.shukla at caviumnetworks.com> wrote:
>> Cc: stable at dpdk.org
>> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
>> test/test/test_mbuf.c | 100 +++++++++++++++++++++++++-------------------------
>> 1 file changed, 51 insertions(+), 49 deletions(-)
> Thank you for doing this fix.
> My only comment is that commit introduces a memory leak, which
> is fixed by your second patch.
> The behavior before your patch was to allocate the pools once
> but never free them.
> The behavior after this patch is to allocate the pools each time
> the test is started and never free them.
> After your 2 patches, the behavior is good.
> So I suggest to merge them into one commit. What do you think?
Yes. Will send v2.
More information about the dev