[dpdk-dev] [PATCH v2] ethdev: remove driver name from device private data

Ferruh Yigit ferruh.yigit at intel.com
Fri Jun 9 17:49:42 CEST 2017

On 6/9/2017 3:22 PM, Ferruh Yigit wrote:
> On 6/7/2017 5:11 PM, Jan Blunck wrote:
>> On Tue, Jun 6, 2017 at 5:10 PM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>>> rte_driver->name has the driver name and all physical and virtual
>>> devices has access to it.
>>> Previously it was not possible for virtual ethernet devices to access
>>> rte_driver->name field (because eth_dev used to keep only pci_dev),
>>> and it was required to save driver name in the device private struct.
>>> After re-works on bus and vdev, it is possible for all bus types to
>>> access rte_driver.
>>> It is able to remove the driver name from ethdev device private data and
>>> use eth_dev->device->driver->name.
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>>> ---
>>> Cc: Gaetan Rivet <gaetan.rivet at 6wind.com>
>>> Cc: Jan Blunck <jblunck at infradead.org>
>>> v2:
>>> * rebase on latest next-net
>> Acked-by: Jan Blunck <jblunck at infradead.org>
> Applied to dpdk-next-net/master, thanks.

Nope. This breaks ring PMD, because it doesn't set eth_dev->device properly.

And the API it provides to create ring PMD makes things more
complicated, because that API doesn't create vdev at all, so when ring
PMD created via API instead of generic way, it doesn't have rte_device
at all ...

I am dropping patch from the next-net, and will send a new version of it.


More information about the dev mailing list