[dpdk-dev] [PATCH 03/12] cryptodev: rename device retrieval argument

Declan Doherty declan.doherty at intel.com
Tue Jun 20 16:35:07 CEST 2017


On 24/05/2017 4:27 PM, Pablo de Lara wrote:
> rte_cryptodev_devices_get() function was parsing a crypto
> device name as an argument, but the function actually
> returns device identifiers of devices that share the
> same crypto driver, so the argument should be driver name, instead.
>
> Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")
> CC: stable at dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> ---
>  lib/librte_cryptodev/rte_cryptodev.c | 2 +-
>  lib/librte_cryptodev/rte_cryptodev.h | 7 ++++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
> index a5a5c36..6880661 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -523,7 +523,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type)
>  }
>
>  uint8_t
> -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices,
> +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices,
>  	uint8_t nb_devices)
>  {
>  	uint8_t i, count = 0;

Compilation breaks after this change, needs next patch to build

> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
> index f307b3b..89093f6 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -464,9 +464,10 @@ extern uint8_t
>  rte_cryptodev_count_devtype(enum rte_cryptodev_type type);
>
>  /**
> - * Get number and identifiers of attached crypto device.
> + * Get number and identifiers of attached crypto devices that
> + * use the same crypto driver.
>   *
> - * @param	dev_name	device name.
> + * @param	driver_name	driver name.
>   * @param	devices		output devices identifiers.
>   * @param	nb_devices	maximal number of devices.
>   *
> @@ -474,7 +475,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type);
>   *   Returns number of attached crypto device.
>   */
>  uint8_t
> -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices,
> +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices,
>  		uint8_t nb_devices);
>  /*
>   * Return the NUMA socket to which a device is connected
>



More information about the dev mailing list