[dpdk-dev] [PATCH v2] net/fm10k: initialize link status in device start

Xiao Wang xiao.w.wang at intel.com
Thu Jun 22 13:20:03 CEST 2017


Fm10k host driver can't manage PHY directly and provides a fake link
status by always reporting LINK_UP. We should initialize link status
in device start, otherwise application will get LINK_DOWN status
when LSC configured.

Fixes: 9ae6068c86da ("fm10k: add dev start/stop")
Cc: stable at dpdk.org

Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
---
v2:
* Rewrite commit message, add information about fm10k PHY.
* Always do link_update in dev_start.
---
 drivers/net/fm10k/fm10k_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 7172a0f..c5c4712 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -84,6 +84,8 @@ static void fm10k_MAC_filter_set(struct rte_eth_dev *dev,
 static void fm10k_set_rx_function(struct rte_eth_dev *dev);
 static void fm10k_set_tx_function(struct rte_eth_dev *dev);
 static int fm10k_check_ftag(struct rte_devargs *devargs);
+static int fm10k_link_update(struct rte_eth_dev *dev,
+	__rte_unused int wait_to_complete);
 
 struct fm10k_xstats_name_off {
 	char name[RTE_ETH_XSTATS_NAME_SIZE];
@@ -1166,6 +1168,8 @@ static inline int fm10k_glort_valid(struct fm10k_hw *hw)
 	if (!(dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG))
 		fm10k_vlan_filter_set(dev, hw->mac.default_vid, true);
 
+	fm10k_link_update(dev, 0);
+
 	return 0;
 }
 
-- 
1.8.3.1



More information about the dev mailing list