[dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez Monroy
> Sent: Friday, June 30, 2017 8:57 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> Subject: [dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk
> 
> Use rte_mempool_put_bulk for both latency and throughput tests instead
> of rte_crypto_op_free to improve application performance.
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>
> ---
>  app/test-crypto-perf/cperf_test_latency.c    | 14 ++++++++------
>  app/test-crypto-perf/cperf_test_throughput.c |  8 ++++----
>  2 files changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c
> index 0c85ac8..4fb7a9a 100644
> --- a/app/test-crypto-perf/cperf_test_latency.c
> +++ b/app/test-crypto-perf/cperf_test_latency.c
> @@ -393,8 +393,10 @@ cperf_latency_test_runner(void *arg)
>  			tsc_end = rte_rdtsc_precise();
> 
>  			/* Free memory for not enqueued operations */
> -			for (i = ops_enqd; i < burst_size; i++)
> -				rte_crypto_op_free(ops[i]);
> +			if (ops_enqd != burst_size)
> +				rte_mempool_put_bulk(ctx->crypto_op_pool,
> +						(void **)&ops_processed[ops_enqd],
> +						burst_size - ops_enqd);
> 
>  			for (i = 0; i < ops_enqd; i++) {
>  				ctx->res[tsc_idx].tsc_start = tsc_start;
> @@ -414,9 +416,9 @@ cperf_latency_test_runner(void *arg)
>  							(ops_processed[i]->opaque_data);
>  					pres->status = ops_processed[i]->status;
>  					pres->tsc_end = tsc_end;
> -
> -					rte_crypto_op_free(ops_processed[i]);
>  				}
> +				rte_mempool_put_bulk(ctx->crypto_op_pool,
> +						(void **)ops_processed, ops_deqd);
> 
>  				deqd_tot += ops_deqd;
>  				deqd_max = max(ops_deqd, deqd_max);
> @@ -450,9 +452,9 @@ cperf_latency_test_runner(void *arg)
>  							(ops_processed[i]->opaque_data);
>  					pres->status = ops_processed[i]->status;
>  					pres->tsc_end = tsc_end;
> -
> -					rte_crypto_op_free(ops_processed[i]);
>  				}
> +				rte_mempool_put_bulk(ctx->crypto_op_pool,
> +						(void **)ops_processed, ops_deqd);
> 
>  				deqd_tot += ops_deqd;
>  				deqd_max = max(ops_deqd, deqd_max);
> diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-
> perf/cperf_test_throughput.c
> index 053dc66..85947a5 100644
> --- a/app/test-crypto-perf/cperf_test_throughput.c
> +++ b/app/test-crypto-perf/cperf_test_throughput.c
> @@ -396,8 +396,8 @@ cperf_throughput_test_runner(void *test_ctx)
>  				 * the crypto operation will change the data and cause
>  				 * failures.
>  				 */
> -				for (i = 0; i < ops_deqd; i++)
> -					rte_crypto_op_free(ops_processed[i]);
> +				rte_mempool_put_bulk(ctx->crypto_op_pool,
> +						(void **)ops_processed, ops_deqd);
> 
>  				ops_deqd_total += ops_deqd;
>  			} else {
> @@ -426,8 +426,8 @@ cperf_throughput_test_runner(void *test_ctx)
>  			if (ops_deqd == 0)
>  				ops_deqd_failed++;
>  			else {
> -				for (i = 0; i < ops_deqd; i++)
> -					rte_crypto_op_free(ops_processed[i]);
> +				rte_mempool_put_bulk(ctx->crypto_op_pool,
> +						(void **)ops_processed, ops_deqd);
> 
>  				ops_deqd_total += ops_deqd;
>  			}
> --
> 2.9.3
Acked-by: Fiona Trahe <fiona.trahe at intel.com>