[dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

[Chas Williams]

On Wed, 2017-03-01 at 19:20 -0500, Allain Legacy wrote:
> +	/* Check current migration status */
> +	if (avp_dev_migration_pending(eth_dev)) {
> +		PMD_DRV_LOG(ERR, "VM live migration operation in progress\n");
> +		return -EBUSY;
> +	}
> +
> +	/* Check BAR resources */
> +	ret = avp_dev_check_regions(eth_dev);
> +	if (ret < 0) {
> +		PMD_DRV_LOG(ERR, "Failed to validate BAR resources, ret=%d\n",
> +			    ret);
> +		return ret;
> +	}
> +
> +	/* Enable interrupts */
> +	ret = avp_dev_setup_interrupts(eth_dev);
> +	if (ret < 0) {
> +		PMD_DRV_LOG(ERR, "Failed to enable interrupts, ret=%d\n", ret);
> +		return ret;
> +	}

I don't see the other side of this to unregister the callback.  It's also
a bit confusing with this here and the other parts in part 15.  It looks
like you enable the interrupts on .dev_create but disable on .dev_stop?
If that's the case, you likely want to just do the setup here and the
enable in .dev_start.