[dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the header file

[Ferruh Yigit]

On 2/23/2017 10:44 AM, Vasily Philipov wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
>> Sent: Wednesday, February 22, 2017 21:05
>> To: Vasily Philipov <vasilyf at mellanox.com>; dev at dpdk.org
>> Cc: Adrien Mazarguil <adrien.mazarguil at 6wind.com>; Nélio Laranjeiro
>> <nelio.laranjeiro at 6wind.com>
>> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the
>> header file
>>
>> On 2/22/2017 1:42 PM, Vasily Philipov wrote:
>>> Make some structs/defines visible from different source files by
>>> placing them into mlx4.h header.
>>>
>>> Signed-off-by: Vasily Philipov <vasilyf at mellanox.com>
>>> ---
>>>  drivers/net/mlx4/mlx4.c | 183
>>> ++--------------------------------------------
>>>  drivers/net/mlx4/mlx4.h | 187
>>> +++++++++++++++++++++++++++++++++++++++++++++++-
>>>  2 files changed, 189 insertions(+), 181 deletions(-)
>>>
>>> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index
>>> 79efaaa..82ccac8 100644
>>> --- a/drivers/net/mlx4/mlx4.c
>>> +++ b/drivers/net/mlx4/mlx4.c
>>> @@ -1,8 +1,8 @@
>>>  /*-
>>>   *   BSD LICENSE
>>>   *
>>> - *   Copyright 2012-2015 6WIND S.A.
>>> - *   Copyright 2012 Mellanox.
>>> + *   Copyright 2012-2017 6WIND S.A.
>>> + *   Copyright 2012-2017 Mellanox.
>>
>> Can someone knowledgeable about Copyright help please?
>>
>> What is the year field in Copyright line for?
>> And above change updates Copyright from 2012 to 2012-2017, is this correct?
>>
> 
> The year line was changes in order to show when the file was changed the last time...

I see, but I don't know if the year field is for last updated date
marker, specially when there are multiple copyright holders.

Overall I don't know why second date is required at all, assuming first
date shows the start date of the work and sets the copyright coverage date.

A comment from who knows more about these issues is welcome.

Thanks,
ferruh