[dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Billy McFall
> Sent: Tuesday, March 7, 2017 2:30 PM
> To: Thomas Monjalon <thomas.monjalon at 6wind.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; olivier.matz at 6wind.com;
> dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed
> buffers in Tx ring
> 
> Thomas,
> 
> Thanks for your comments. See inline.
> 
> On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon
> <thomas.monjalon at 6wind.com>
> wrote:
> 
> > 2017-01-27 13:37, Billy McFall:
> > > --- a/doc/guides/nics/features/default.ini
> > > +++ b/doc/guides/nics/features/default.ini
> > > @@ -55,6 +55,7 @@ FW version           =
> > >  EEPROM dump          =
> > >  Registers dump       =
> > >  Multiprocess aware   =
> > > +Free TX ring buffers =
> >
> > I'm afraid this wording will be confusing, because every drivers free
> > their buffers :) What about "Free Tx mbuf on demand" ?
> >
> >
> I definitely like your wording of the feature better than mine. All the
> existing features were under 20 characters and I was trying to stay under
> that.

Hi Billy,

"Free Tx mbuf on demand" looks clearer to me as well. You will probably have to
modify doc/guides/conf.py to support labels longer than 20 characters. Like the
following, or better still a global variable for feature width.


$ git diff
diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index 34c62de..3f3ce00 100644
--- a/doc/guides/conf.py
+++ b/doc/guides/conf.py
@@ -300,7 +300,7 @@ def print_table_body(outfile, num_cols, ini_files, ini_data, default_features):
 def print_table_row(outfile, feature, line):
     """ Print a single row of the table with fixed formatting. """
     line = line.rstrip()
-    print('   {:<20}{}'.format(feature, line), file=outfile)
+    print('   {:<25}{}'.format(feature, line), file=outfile)
 
 
 def print_table_divider(outfile, num_cols):
@@ -309,7 +309,7 @@ def print_table_divider(outfile, num_cols):
     column_dividers = ['='] * num_cols
     line += ' '.join(column_dividers)
 
-    feature = '=' * 20
+    feature = '=' * 25
 
     print_table_row(outfile, feature, line)

John