[dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

Mcnamara, John john.mcnamara at intel.com
Thu Mar 9 11:42:13 CET 2017

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur
> Sent: Wednesday, March 8, 2017 9:32 PM
> To: dev at dpdk.org; Ananyev, Konstantin <konstantin.ananyev at intel.com>;
> Richardson, Bruce <bruce.richardson at intel.com>
> Cc: Ravi Kerur <rkerur at gmail.com>
> Subject: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code
> into l3fwd
> Merge l3fwd-acl code into l3fwd with '-A' cmdline option to run ACL.

Hi Ravi,

The subject line and commit message are okay. the only issue is that
the version information should be after a triple dash line so that
is doesn't appear in the commit message.

The version information is intended for reviewers so that know what
has changed since the last version. Just put the following before it:


> v5:
> 	> None.
> v4:
>         > Initialize rss_hf to IP for LPM, EM and ACL.
>         > Update rss_hf with l4 in parse_args for ACL.
>         > Fix pending checkpatch code indentation warning.

This applies to all the commit messages.


More information about the dev mailing list