[dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool

[Olivier Matz]

Hi Hemant,

On Tue, 14 Mar 2017 12:12:17 +0530, Hemant Agrawal <hemant.agrawal at nxp.com> wrote:
> On 3/9/2017 11:27 AM, Hemant Agrawal wrote:
> > On 3/8/2017 9:09 PM, Thomas Monjalon wrote:  
> >> 2017-03-08 18:22, Hemant Agrawal:  
> >>>> On Fri, 3 Mar 2017 18:16:36 +0530, Hemant Agrawal
> >>>> <hemant.agrawal at nxp.com> wrote:
> >>>> I think the current mempool handlers should be moved first in a
> >>>> separate patch.  
> >>
> >> Yes it should have been done earlier.
> >>  
> >>> Are you seeing any benefit by making it a separate patch series?  
> >>
> >> A separate patchset for moving mempool handlers will be easy to review
> >> and accept.
> >> If integrated in this series, it is kind of hidden and prevent the
> >> visibility and review it deserves.
> >> By the way the mempool move should be directly committed in the main
> >> repository, while this series targets next-net.
> >>  
> >
> > hw mempool has dependency on mc-bus. So, we will break it into *5* series,
> >
> > 1. mc-bus - which can go on main repo - Rebased over main repo
> > 2. dpaa2-pool - it can also go on main rep (depends on mc-bus) - Rebased
> > over 'main repo + 1'.
> > 3. dpaa2-pmd - this depends on mc-bus and dpaa2-pool
> >       A. mc-bus -another series rebased over net-next
> >       B. dpaa2-pool - another series rebased over 'net-next + A'
> >       C. the pmd itself rebased over 'net-next + A + B'
> >
> > Are you sure, you will like us to do the above and flood the mailing
> > list :)
> >
> > I think, this will make the review difficult.
> >
> > Bruce, Ferruh, Olivier - does the above help you? If so, we can do it.  
> 
> Any views, we can rebase our next version accordingly.
> we are looking forward to get it merged in 17.05.

Yes, moving the other mempool drivers in the drivers/ directory
before adding another one there makes sense to me, in order to
avoid having two places for mempool handlers.

As Thomas stated, it's probably better to have it in another
patchset, so it can be quickly reviewed and integrated.

Regards,
Olivier