[dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver

[Ferruh Yigit]

On 3/21/2017 2:38 PM, Jerin Jacob wrote:
> On Tue, Mar 21, 2017 at 02:31:41PM +0000, Ferruh Yigit wrote:
>> On 3/20/2017 2:10 PM, Jerin Jacob wrote:
>>> - bgx_link_status mbox definition was changed in Linux
>>> commit 1cc702591bae ("net: thunderx: Add ethtool support")
>>> - NIC_MBOX_MSG_RES_BIT related changes were never part of Linux PF driver
>>>
>>> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
>>
>> <...>
>>
>>> @@ -157,6 +151,7 @@ struct rss_cfg_msg {
>>>  /* Physical interface link status */
>>>  struct bgx_link_status {
>>>  	uint8_t    msg;
>>> +	uint8_t    mac_type;
>>
>> Hi Jerin,
>>
>> Is this modification related to this patch?
> 
> Yes Ferruh.
> 
> This was related to the following section in git log comment.
> ----
> - bgx_link_status mbox definition was changed in Linux
> commit 1cc702591bae ("net: thunderx: Add ethtool support") 
> ---

I see now, thanks. Since this is to sync with Linux PF, shouldn't it be
used in driver, perhaps something like in Linux driver:
"nic->mac_type = mbx.link_status.mac_type"

What is the point of just adding definition without using it?

> 
> 
>>
>>>  	uint8_t    link_up;
>>>  	uint8_t    duplex;
>>>  	uint32_t   speed;
>>>
>>