[dpdk-dev] [PATCH] devtools: make log checking script BSD-compatible

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Mar 27 23:45:01 CEST 2017


2017-03-23 15:09, Bruce Richardson:
> The -e flag to readlink doesn't exist on FreeBSD so change it to -f instead
> which is present on both BSD and Linux. Error reported is:
> 
>   readlink: illegal option -- e
>   usage: readlink [-fn] [file ...]
>   usage: dirname string [...]
>   ./devtools/check-git-log.sh: /git-log-fixes.sh: not found
> 
> Fixes: 814c8822ef7b ("scripts: check cc stable mailing list in commit")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
[...]
> -selfdir=$(dirname $(readlink -e $0))
> +selfdir=$(dirname $(readlink -f $0))

You win the prize of the shortest fix with only one letter! :)

Applied, thanks


More information about the dev mailing list