[dpdk-dev] [PATCH v5 7/7] net/ark: Arkville PMD component integration

Adrien Mazarguil adrien.mazarguil at 6wind.com
Tue Mar 28 17:00:07 CEST 2017


On Tue, Mar 28, 2017 at 03:38:13PM +0100, Ferruh Yigit wrote:
> On 3/23/2017 11:01 PM, Ed Czeck wrote:
> > * Flesh out device configuration
> > * Add links dev_ops
> > * allow dynamic extension loading
> > 
> > Signed-off-by: Shepard Siegel <shepard.siegel at atomicrules.com>
> > Signed-off-by: John Miller <john.miller at atomicrules.com>
> > Signed-off-by: Ed Czeck <ed.czeck at atomicrules.com>
[...]
> > +	/*
> > +	 * We will create additional devices based on the number of requested
> > +	 * ports
> > +	 */
> > +	int pc = 1;
> > +	int p;
> 
> I am aware some people prefer the declaring variables close to context,
> which is good idea, but if I remember correct, there was a patchset,
> from Adrien, to make DPDK C99 compatible, will this break it?
[...]

Only replying to this part, declaring variables anywhere is fine since C99,
so no problem. This is not the preferred style in DPDK as abusing this
sometimes makes the code less readable (can lead to super large functions
without consistent code blocks).

-- 
Adrien Mazarguil
6WIND


More information about the dev mailing list