[dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release
arybchenko at solarflare.com
Wed Mar 29 18:37:48 CEST 2017
On 03/29/2017 07:25 PM, Ferruh Yigit wrote:
> On 3/29/2017 4:08 PM, Andrew Rybchenko wrote:
>> Datapath TxQ handle is passed to release function, not control path.
>> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath")
>> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
>> Please, squash the patch into 5808dbaf751f.
> Hi Andrew,
> To clarify, for the commits in next-net tree that are not merged yet, we
> can benefit from sub-tree re-writable option and squash some fixes,
> -without over using it.
Yes, it is perfectly clear.
> But for this patch, as far as I can see, original code added with
> commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues")
> which is part of v17.02 release.
If we take a look a lines, yes, these lines belong to
b1b7ad933b39 ("net/sfc: set up and release Tx queues")
however the breakage is introduced by
19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath")
since it registers pointer to the so-called datapath Tx queue in the
instead of previous used control path Tx queue pointer.
> So, please send a patch with correct fixes line and it won't be squashed.
Correct fixes line for the patch with current dpdk-next-net is:
Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath")
which is in dpdk-next-net tree only. Should I resend it?
More information about the dev