[dpdk-dev] [PATCH v13 6/6] app/test-pmd: add latency statistics calculation

Pattan, Reshma reshma.pattan at intel.com
Thu Mar 30 12:22:29 CEST 2017


Hi,

Few nits. 

> -----Original Message-----
> From: Horton, Remy
> Sent: Wednesday, March 29, 2017 7:29 PM
> To: dev at dpdk.org
> Cc: Pattan, Reshma <reshma.pattan at intel.com>; Thomas Monjalon
> <thomas.monjalon at 6wind.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>
> Subject: [PATCH v13 6/6] app/test-pmd: add latency statistics calculation
> 
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> 28db8cd..30b60ba 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -1,7 +1,7 @@
> +#ifdef RTE_LIBRTE_LATENCY_STATS
> +	printf("  --latencystats=N: enable latency and jitter statistcs "
> +	       "monitoring on lcore id N.\n"); #endif

In the above printf , we need to mention "monitoring on forwarding lcore id"

> +		{ "latencystats",               1, 0, 0 },
Do we need to add ifdef RTE_LIBRTE_LATENCY_STATS flag here also ?


> pmd/testpmd.h b/app/test-pmd/testpmd.h index 8cf2860..f0652ee 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -1,7 +1,7 @@
>  /*-

Do we need to add ifdef RTE_LIBRTE_LATENCY_STATS flag here also ?
> +
> +extern uint8_t latencystats_enabled;
> +extern lcoreid_t latencystats_lcore_id;

Thanks,
Reshma


More information about the dev mailing list