[dpdk-dev] [PATCH] app/testpmd: add bus info when display port info

[Pei, Yulong]

Hi Thomas,


-----Original Message-----
From: Thomas Monjalon [mailto:thomas at monjalon.net] 
Sent: Monday, May 1, 2017 9:56 PM
To: Pei, Yulong <yulong.pei at intel.com>
Cc: dev at dpdk.org; Wu, Jingjing <jingjing.wu at intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port info

26/04/2017 06:31, Yulong Pei:
> Display pci device bus info when show port info.
> 
> Signed-off-by: Yulong Pei <yulong.pei at intel.com>
> ---
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -469,6 +469,14 @@ port_infos_display(portid_t port_id)
>  	print_ethaddr("MAC address: ", &mac_addr);
>  	printf("\nDriver name: %s", dev_info.driver_name);
>  	printf("\nConnect to socket: %u", port->socket_id);
> +	if (dev_info.pci_dev)
> +		printf("\nBus-info: %04x:%02x:%02x:%x",
> +			dev_info.pci_dev->addr.domain,
> +			dev_info.pci_dev->addr.bus,
> +			dev_info.pci_dev->addr.devid,
> +			dev_info.pci_dev->addr.function);
> +	else
> +		printf("\nBus-info: N/A");

The bus information must be managed in a more generic way.
The field pci_dev will probably be removed in a next release.

Could you kind to tell me more information about what does "more generic way" mean ?

Best Regards
Yulong Pei