[dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx

Olivier Matz olivier.matz at 6wind.com
Tue May 9 09:24:37 CEST 2017


On Thu,  4 May 2017 16:43:58 +0100, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> mbuf next and nb_segs fields already have the default values when get
> from mempool, no need to update them in PMD.
> 
> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> Cc: Olivier Matz <olivier.matz at 6wind.com>
> ---
>  drivers/net/null/rte_eth_null.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index abf3ec7..2c94339 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
>  					packet_size);
>  		bufs[i]->data_len = (uint16_t)packet_size;
>  		bufs[i]->pkt_len = packet_size;
> -		bufs[i]->nb_segs = 1;
> -		bufs[i]->next = NULL;
>  		bufs[i]->port = h->internals->port_id;
>  	}
>  

Reviewed-by: Olivier Matz <olivier.matz at 6wind.com>



More information about the dev mailing list