[dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

[Roger B Melton]

-stable at dpdk.org per Thomas

I know this patch has already been applied but to complete the loop, I 
have applied the patch to 17.05-rc4 and verified within my application 
that the NULL function pointer issue for ixgbe_vf has been resolved.


Regards,
Roger

On 5/10/17 3:00 AM, Wei Dai wrote:
> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
> be called directly. It had better be replaced by calling
> ixgbe_get_media_type( ) to avoid crash.
>
> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
> Cc: stable at dpdk.org
>
> Signed-off-by: Wei Dai <wei.dai at intel.com>
Tested-by Roger B Melton <rmelton at cisco.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec667d8..ed2baec 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>   	hw->mac.get_link_status = true;
>   
>   	if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
> -		hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
> +		ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>   		speed = hw->phy.autoneg_advertised;
>   		if (!speed)
>   			ixgbe_get_link_capabilities(hw, &speed, &autoneg);