[dpdk-dev] [PATCH v2 00/25] bnxt patchset

[Ferruh Yigit]

On 5/26/2017 7:39 PM, Ajit Khaparde wrote:
> This patchset amongst other changes adds support few more dev_ops,
> updates HWRM to version 1.7.7, switches to polling stats from the
> hardware, support for Jumbo MTU, LRO etc..
> As suggedted for the previous submission:
>  Grouped in the end, it also has PMD specific APIs to control VF from PF.
>  I have updated the release notes and the features file wherever possible.
> 
> --
>   bnxt: update to new HWRM version
>   bnxt: code reorg to properly allocate resources for PF/VF
>   bnxt: handle VF/PF initialization appropriately
>   bnxt: support lack of huge pages
>   bnxt: add additonal HWRM debug info to error messages
>   bnxt: add tunneling support
>   bnxt: add support for xstats get/reset
>   bnxt: Add support for VLAN filter and strip dev_ops
>   bnxt: add support for set multicast addr list and MAC addr set
>   bnxt: add support for fw_version_get dev_op
>   bnxt: add support to set MTU
>   bnxt: add support for LRO
>   bnxt: add rxq/txq info_get dev_ops
>   bnxt: add code to support VLAN pvid set dev_op
>   bnxt: reorg the query stats code
>   bnxt: add support for led on/off
>   bnxt: add support for tx loopback, set vf mac and queues drop
>   bnxt: add support for set VF QOS and MAC anti spoof
>   bnxt: add support for VLAN stripq, anti spoof and filtering for VFs
>   bnxt: add support to get and clear VF specific stats
>   bnxt: add code to determine the Rx status of VF
>   bnxt: add support to add a VF MAC address
>   bnxt: add code to configure a default VF VLAN
>   bnxt: Add support to set VF rxmode
>   update release notes

I have sent some comments for the patchset.

Also generic to the whole patchset, there are a few minor details it
would be helpful if you can apply in next version of the patchset
(otherwise maintainers have to fix them) :

- rebase patchset on top of latest next-net, there are two easy to fix
conflicts because of merged patches to next-net

- patch subject starts with "next/bnxt: " for driver and "doc: " for
document patch.

- in patch subject, after ":", sentences starts with lowercase char

- instead mentioning added dev_ops name in the patch subject, it would
be better to mention feature added.

Thanks,
ferruh