[dpdk-dev] [PATCH] app/testpmd: fix potential memory leak

Kirill Rybalchenko kirill.rybalchenko at intel.com
Thu Nov 2 11:13:41 CET 2017


Fix potential memory leak in cmd_ddp_info_parsed() function.

Fixes: a8e005696c7b ("app/testpmd: get ddp profile protocol info")

Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko at intel.com>
---
 app/test-pmd/cmdline.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3b691fe..eb044e7 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14362,7 +14362,7 @@ cmd_ddp_info_parsed(
 	uint32_t dev_num = 0;
 	struct rte_pmd_i40e_ddp_device_id *devs;
 	uint32_t proto_num = 0;
-	struct rte_pmd_i40e_proto_info *proto;
+	struct rte_pmd_i40e_proto_info *proto = NULL;
 	uint32_t pctype_num = 0;
 	struct rte_pmd_i40e_ptype_info *pctype;
 	uint32_t ptype_num = 0;
@@ -14541,9 +14541,10 @@ cmd_ddp_info_parsed(
 	free(ptype);
 	printf("\n");
 
-	free(proto);
 	ret = 0;
 no_print_return:
+	if (proto)
+		free(proto);
 #endif
 	if (ret == -ENOTSUP)
 		printf("Function not supported in PMD driver\n");
-- 
2.5.5



More information about the dev mailing list