[dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide

Iremonger, Bernard bernard.iremonger at intel.com
Thu Nov 2 18:29:24 CET 2017


Hi John,

<snip>

> > Subject: [PATCH 1/2] doc: flow classify library prog guide
> >
> > This file documents the Flow Classification library, librte_flow_classify.
> >
> > Updated MAINTAINERS file
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> 
> Hi Bernard,
> 
> Thanks for the doc.
> 
> There is a doc build warning due to a reference to a file that is in the 2/2
> patch:
> 
>     $ make doc-guides-html  -j
>     sphinx processing guides-html...
>     /work/dpdk_docs/doc/guides/prog_guide/flow_classify_lib.rst:64:
>     WARNING: unknown document: ../sample_app_ug/flow_classify
> 
Both docs reference each other.
I could squash the patches into one, or add a third patch with the reference.
Which option would you prefer? 

> 
> There are also 2 x s/classifer/classifier/ typos in this patch and 1 in 2/2.

I will fix typo's
> 
> John
> 
> 
Thanks for the review.

Regards,

Bernard.



More information about the dev mailing list