[dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to drivers/bus

Thomas Monjalon thomas at monjalon.net
Tue Nov 7 03:43:20 CET 2017


Hi Jianfeng,

This patch needs a rebase and some changes as described below.
Would you have time to fix it quickly please?

30/10/2017 09:28, Jianfeng Tan:
>  create mode 100644 lib/librte_eal/common/.eal_common_dev.c.swp
[...]
>  create mode 100644 test/test/autotest_data.pyc
>  create mode 100644 test/test/autotest_test_funcs.pyc

These files should not be in the patch.


> --- a/config/common_base
> +++ b/config/common_base
> @@ -814,3 +814,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=y
>  # Compile the eventdev application
>  #
>  CONFIG_RTE_APP_EVENTDEV=y
> +
> +#
> +# Compile the vdev bus
> +#
> +CONFIG_RTE_LIBRTE_VDEV_BUS=y

Please move this option in a more logical position.


> --- a/drivers/crypto/Makefile
> +++ b/drivers/crypto/Makefile
> @@ -32,6 +32,7 @@
>  include $(RTE_SDK)/mk/rte.vars.mk
>  
>  core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_cryptodev
> +core-libs += librte_bus_vdev

The library dependencies have changed.
You must add the dependency to LDLIBS in each PMD Makefile.


> --- a/lib/librte_eal/linuxapp/eal/Makefile
> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> -LIBABIVER := 6
> +LIBABIVER := 7

No need to bump again the EAL version in 17.11.


> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -lrte_mempool_ring
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_RING)           += -lrte_ring
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI)            += -lrte_pci
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)            += -lrte_eal
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_BUS)       += -lrte_bus_vdev

I suggest to move by one line just before -lrte_eal.



More information about the dev mailing list