[dpdk-dev] [PATCH v2] net/mlx4: improve Rx packet type offloads report

Thomas Monjalon thomas at monjalon.net
Wed Nov 8 20:56:03 CET 2017


08/11/2017 19:47, Moti Haimovsky:
> This patch improves Rx packet type offload report in case the device is
> a virtual function device.
> In these devices we observed that the L2 tunnel flag is set also for
> non-tunneled packets, this leads to a complete misinterpretation of the
> packet type being received.
> This issue occurs since the tunnel_mode is not set to 0x7 by the driver
> for virtual devices and therefore the value in the L2 tunnel flag is
> meaningless and should be ignored.
> 
> Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads")
> 
> Signed-off-by: Moti Haimovsky <motih at mellanox.com>
> ---
> V2:
> Modification according to inputs from Adrien Mazarguil
> * Modified the commit message to explain the issue.
> * Removed redundant l2 tunnel offload bit.
> * Modified mlx4_dev_supported_ptypes_get to report the supported
>   packet types according to the device in hand.
> ---

As it is a v2, it should be threaded with v1.
Please remind to use --in-reply-to.

Just looking at the title, we should not take it for RC3.
But reading the commit message, especially "this leads to a
complete misinterpretation of the packet type being received",
it appears fixing a real bug. In this case, the title should be
	"net/mlx4: fix Rx packet type offloads"



More information about the dev mailing list