[dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection

Jerin Jacob jerin.jacob at caviumnetworks.com
Sun Nov 19 05:55:31 CET 2017


Use of rte_eal_mbuf_default_mempool_ops() API will
allow to override pool handler through "--mbuf-pool-ops-name"
eal command line argument.

Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
---
 test/test/test_mempool_perf.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index 749b364ee..85b9f782d 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -313,6 +313,7 @@ test_mempool_perf(void)
 	struct rte_mempool *mp_cache = NULL;
 	struct rte_mempool *mp_nocache = NULL;
 	struct rte_mempool *default_pool = NULL;
+	const char *default_pool_ops;
 	int ret = -1;
 
 	rte_atomic32_init(&synchro);
@@ -336,6 +337,7 @@ test_mempool_perf(void)
 	if (mp_cache == NULL)
 		goto err;
 
+	default_pool_ops = rte_eal_mbuf_default_mempool_ops();
 	/* Create a mempool based on Default handler */
 	default_pool = rte_mempool_create_empty("default_pool",
 						MEMPOOL_SIZE,
@@ -344,21 +346,18 @@ test_mempool_perf(void)
 						SOCKET_ID_ANY, 0);
 
 	if (default_pool == NULL) {
-		printf("cannot allocate %s mempool\n",
-		       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+		printf("cannot allocate %s mempool\n", default_pool_ops);
 		goto err;
 	}
 
-	if (rte_mempool_set_ops_byname(default_pool,
-				       RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL)
+	if (rte_mempool_set_ops_byname(default_pool, default_pool_ops, NULL)
 				       < 0) {
-		printf("cannot set %s handler\n", RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+		printf("cannot set %s handler\n", default_pool_ops);
 		goto err;
 	}
 
 	if (rte_mempool_populate_default(default_pool) < 0) {
-		printf("cannot populate %s mempool\n",
-		       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+		printf("cannot populate %s mempool\n", default_pool_ops);
 		goto err;
 	}
 
@@ -378,7 +377,7 @@ test_mempool_perf(void)
 
 	/* performance test with 1, 2 and max cores */
 	printf("start performance test for %s (without cache)\n",
-	       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+	       default_pool_ops);
 
 	if (do_one_mempool_test(default_pool, 1) < 0)
 		goto err;
-- 
2.15.0



More information about the dev mailing list