[dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue

Yang, Zhiyong zhiyong.yang at intel.com
Thu Nov 23 02:57:16 CET 2017


Hi Yanglong,

Good catch!  Thanks for your patch.

Thanks
Zhiyong
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, November 23, 2017 9:27 AM
> To: dev at dpdk.org
> Cc: Wu, Yanglong <yanglong.wu at intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> 
> the port_id was allocated as a inccrete number, for init function was
> passthroughed a wrong size of parameter

The commit log is not clear enough.

> 
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu at intel.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f71d96301..8990ebf6b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
>  			      tp_id, UINT16);
>  cmdline_parse_token_num_t cmd_vlan_tpid_portid =
>  	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> -			      port_id, UINT8);
> +			      port_id, UINT16);
> 
>  cmdline_parse_inst_t cmd_vlan_tpid = {
>  	.f = cmd_vlan_tpid_parsed,
> --
> 2.11.0



More information about the dev mailing list