[dpdk-dev] [PATCH] net/mlx5: cleanup the allocation of the buffer used for the ethtool stats

Thierry Herbelot thierry.herbelot at 6wind.com
Thu Nov 23 14:06:27 CET 2017


On 11/23/2017 02:00 PM, Shahaf Shuler wrote:
> Hi Thierry
> 
> Friday, November 17, 2017 9:55 AM, Nelio Laranjeiro:
>>> 2.11.0
>>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
> 
> Am having the following check-git-log errors:
> 
> Headline too long:
>          net/mlx5: cleanup the allocation of the buffer used for the ethtool stats
> Wrong tag:
>          Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics')
> Wrong 'Fixes' reference:
>          Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics')
> Is it candidate for Cc: stable at dpdk.org backport?
>          net/mlx5: cleanup the allocation of the buffer used for the ethtool stats
> 
> is the below suggestion[1] acceptable? If so I will merge into next-net-mlx
> 
> [1]
> Author: Thierry Herbelot <thierry.herbelot at 6wind.com>
> Date:   Fri Nov 17 14:51:34 2017 +0100
> 
>      net/mlx5: cleanup allocation of ethtool stats
>      
>      Simplify the computation for the needed size:
>      - exact size for the structure header,
>      - exact size for a number of 64-bit counters.
>      
>      Fixes: a4193ae3bc4f ("net/mlx5: support extended statistics")
>      Cc: stable at dpdk.org
>      
>      Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
>      Acked-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>


Hello Shahaf

Your suggestion is excellent: thanks for it.

	Best regards

	Thierry
> 
> 
> 
> 
>>
>> Thanks,
>>
>> --
>> Nélio Laranjeiro
>> 6WIND


-- 
Thierry Herbelot
6WIND
Software Engineer



More information about the dev mailing list