[dpdk-dev] [PATCH v6 1/3] eal/x86: run-time dispatch over memcpy

[Ananyev, Konstantin]

> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Thursday, October 5, 2017 12:27 PM
> To: Li, Xiaoyun <xiaoyun.li at intel.com>; Ananyev, Konstantin <konstantin.ananyev at intel.com>; Richardson, Bruce
> <bruce.richardson at intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhang, Helin <helin.zhang at intel.com>; dev at dpdk.org; Thomas Monjalon
> (thomas.monjalon at 6wind.com) <thomas.monjalon at 6wind.com>
> Subject: RE: [PATCH v6 1/3] eal/x86: run-time dispatch over memcpy
> 
> Another thing, if add 17.11, the end is 17.08 or EXPERIMENTAL?

I don't see why to go experimental here - you are not adding new API,
Just a rework of existing one (rte_memcpy()) and rte_memcpy_ptr is exposed
Just for performance reasons.
So my vote would be for 17.11.
Konstantin 

> 
> Best Regards,
> Xiaoyun Li
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Li, Xiaoyun
> > Sent: Thursday, October 5, 2017 19:19
> > To: Ananyev, Konstantin <konstantin.ananyev at intel.com>; Richardson,
> > Bruce <bruce.richardson at intel.com>
> > Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhang, Helin
> > <helin.zhang at intel.com>; dev at dpdk.org; Thomas Monjalon
> > (thomas.monjalon at 6wind.com) <thomas.monjalon at 6wind.com>
> > Subject: Re: [dpdk-dev] [PATCH v6 1/3] eal/x86: run-time dispatch over
> > memcpy
> >
> >
> >
> > > -----Original Message-----
> > > From: Ananyev, Konstantin
> > > Sent: Thursday, October 5, 2017 17:37
> > > To: Li, Xiaoyun <xiaoyun.li at intel.com>; Richardson, Bruce
> > > <bruce.richardson at intel.com>
> > > Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhang, Helin
> > > <helin.zhang at intel.com>; dev at dpdk.org; Thomas Monjalon
> > > (thomas.monjalon at 6wind.com) <thomas.monjalon at 6wind.com>
> > > Subject: RE: [PATCH v6 1/3] eal/x86: run-time dispatch over memcpy
> > >
> > > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > > b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > > index 8c08b8d..15a2fe9 100644
> > > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > > @@ -241,5 +241,6 @@ EXPERIMENTAL {
> > > >  	rte_service_runstate_set;
> > > >  	rte_service_set_stats_enable;
> > > >  	rte_service_start_with_defaults;
> > > > +	rte_memcpy_ptr;
> > > >
> > > >  } DPDK_17.08;
> > >
> > > I am not an expert in DPDK versioning system, But shouldn't we create
> > > a
> > > 17.11 section here?
> > Should we create a 17.11 section? I am not sure who to ask for.
> >
> > > Also I think an alphabetical order should be preserved here.
> > OK.
> >
> > > Konstantin