[dpdk-dev] [PATCH v2 4/4] net/bnxt: fix some unnecessary parentheses

Ajit Khaparde ajit.khaparde at broadcom.com
Thu Oct 5 17:06:46 CEST 2017


This patch removes some unnecessary parentheses from the code.

Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------
 drivers/net/bnxt/bnxt_filter.c |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c559a9db8..636f09a66 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1734,9 +1734,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
 		STAILQ_FOREACH(mfilter, &vnic0->filter, next) {
 			if ((!memcmp(efilter->mac_addr.addr_bytes,
 				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
-			     (mfilter->flags ==
-			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
-			     (mfilter->ethertype == efilter->ether_type))) {
+			     mfilter->flags ==
+			     HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP &&
+			     mfilter->ethertype == efilter->ether_type)) {
 				match = 1;
 				break;
 			}
@@ -1745,9 +1745,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
 		STAILQ_FOREACH(mfilter, &vnic->filter, next)
 			if ((!memcmp(efilter->mac_addr.addr_bytes,
 				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
-			     (mfilter->ethertype == efilter->ether_type) &&
-			     (mfilter->flags ==
-			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {
+			     mfilter->ethertype == efilter->ether_type &&
+			     mfilter->flags ==
+			     HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX)) {
 				match = 1;
 				break;
 			}
diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
index 3eaa7e45a..d470be259 100644
--- a/drivers/net/bnxt/bnxt_filter.c
+++ b/drivers/net/bnxt/bnxt_filter.c
@@ -612,7 +612,7 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_item pattern[],
 
 			if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
 			    vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
-			    (vxlan_spec->flags != 0x8)) {
+			    vxlan_spec->flags != 0x8) {
 				rte_flow_error_set(error, EINVAL,
 					   RTE_FLOW_ERROR_TYPE_ITEM,
 					   item,
@@ -659,8 +659,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_item pattern[],
 				return -rte_errno;
 			}
 
-			if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
-			    (nvgre_spec->protocol != 0x6558)) {
+			if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
+			    nvgre_spec->protocol != 0x6558) {
 				rte_flow_error_set(error, EINVAL,
 					   RTE_FLOW_ERROR_TYPE_ITEM,
 					   item,
-- 
2.13.5 (Apple Git-94)



More information about the dev mailing list