[dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well

[Hemant Agrawal]

On 10/6/2017 5:11 AM, Thomas Monjalon wrote:
> 13/07/2017 13:48, Hemant Agrawal:
>> In case no_pci is configured, fslmc bus will still need the
>> the vfio to be enabled.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
>> ---
>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> +#ifdef RTE_LIBRTE_FSLMC_BUS
>> +	if (!vfio_enabled) {
>> +		if (!vfio_enable("vfio_fsl_mc"))
>> +			vfio_enabled = 1;
>> +	}
>> +#endif
>
> It seems to be a hack.
> VFIO is not only PCI.
> Why --no-pci is impacting VFIO?
>
> Anatoly?
>

At present there are only 2 users of VFIO. PCI and fsl-mc bus.


One options is that we always enable vfio irrespective of --no-pci flag. 
My believe is that vfio-pci will be present in most system supporting 
any other flavor of vfio (platform, fsl-mc etc).

The other option is what I proposed. i.e. if vfio is not already enabled 
the platform is FSLMC bus, enable it.

regards,
Hemant