[dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

Thomas Monjalon thomas at monjalon.net
Sun Oct 8 18:43:47 CEST 2017


08/10/2017 14:40, Santosh Shukla:
> This commit adds a section to the docs listing the mempool
> device PMDs available.

It is confusing to add a mempool guide, given that we already have
a mempool section in the programmer's guide:
	http://dpdk.org/doc/guides/prog_guide/mempool_lib.html

And we will probably need also some doc for bus drivers.

I think it would be more interesting to create a platform guide
where you can describe the bus and the mempool.
OK for doc/guides/platform/octeontx.rst ?

I choose to integrate this series without this last patch.
I mark this patch as rejected.
Please submit a new one separately.

> It then adds the octeontx fpavf mempool PMD to the listed mempool
> devices.
> 
> Cc: John McNamara <john.mcnamara at intel.com>
> 
> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> Reviewed-by: John McNamara <john.mcnamara at intel.com>
> ---
[...]
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -340,6 +340,13 @@ F: drivers/net/liquidio/
>  F: doc/guides/nics/liquidio.rst
>  F: doc/guides/nics/features/liquidio.ini
>  
> +Cavium Octeontx Mempool
> +M: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> +M: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> +F: drivers/mempool/octeontx

A slash is missing at the end of the directory.

Until now, the mempool and bus drivers are listed with net drivers.
We could move them in a platform section later.
For now, let's put it as "Cavium OcteonTX" in net drivers.

I fixed and merged it with the first patch.

> +F: doc/guides/mempool/index.rst

The index must not be part of Octeontx section.

> +F: doc/guides/mempool/octeontx.rst


More information about the dev mailing list