[dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers

[Shreyansh Jain]

On Wednesday 11 October 2017 04:12 PM, Tan, Jianfeng wrote:
> 
> 
> On 10/11/2017 2:54 PM, Shreyansh Jain wrote:
>> Hello Jianfeng,
>>
>> On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote:
>>>
> [...]
>>> -#define PMD_DRV_LOG(level, fmt, args...) \
>>> -    PMD_DRV_LOG_RAW(level, fmt "\n", ## args)
>>> +#define FSLMC_VFIO_LOG(level, fmt, args...) \
>>> +    RTE_LOG(level, EAL, "%s(): " fmt "\n", __func__, ##args)
>>
>> This change breaks the FSLMC bus driver. There are macros like 
>> PMD_DRV_LOG which are still in use in the code.
>> Before removing the above, those would have to be restructured.
> 
> Just try to change all PMD_DRV_LOG in fslmc to FSLMC_VFIO_LOG. As you 
> are working on that, I will drop it. >
>>
>> I am already working on converting this logging into dynamic logging.
>> Can you skip this work until then? Does it block your work?
> 
> Do you mean you are working on introducing a new log type for bus drivers?

A dynamic log type using rte_log_register. So, "bus.fslmc", "net.dpaa2" 
and so on. I am not introducing LOGTYPE_BUS.

In past [1], I sent a patch for LOGTYPE_BUS but at that time I 
understood that dynamic logging is the preferred way.

[1] http://dpdk.org/dev/patchwork/patch/24478/


> 
> Thanks,
> Jianfeng
>