[dpdk-dev] [PATCH 0/6] fix port id type

Ferruh Yigit ferruh.yigit at intel.com
Thu Oct 12 22:12:49 CEST 2017


On 10/12/2017 7:03 PM, Ferruh Yigit wrote:
> On 10/12/2017 10:32 AM, Zhiyong Yang wrote:
>> Now ethdev port_id has been increased to uint16_t from uint8_t in the below patch
>> http://www.dpdk.org/dev/patchwork/patch/29418/
>>
>> but
>> 1. Some features which are applied were still developed based on older version
>> uint8_t port_id.
>> 2. Some places using port id such as testpmd are omitted in previous patch.
>> The patchset fixes some port id type issues.
>>
>> Zhiyong Yang (6):
>>   lib/librte_ether: fix port id type
>>   net/bnxt: fix port id type
>>   net/liquidio: fix port id type
>>   app/pdump: fix port id type
>>   app/proc_info: fix port id type
>>   app/testpmd: fix port id type
> 
> Series applied to dpdk-next-net/master, thanks.
> 
> 
> Thanks for the patches!
> But I can see there are still more uint8_t usage [1], some looks valid.
> 
> I aware this looks like never it will never end but would you mind doing
> one more go? It would be nice to get all fixed before rc1.
> And I hope we won't need to change port_id storage type again...
> 
> 
> [1]
> $ git grep -c "uint8_t port_id"

And (git grep "uint8_t port") yields even more result.

> app/test-eventdev/test_order_common.h:2
> app/test-eventdev/test_perf_common.h:2
> doc/guides/prog_guide/eventdev.rst:1
> doc/guides/prog_guide/poll_mode_drv.rst:1
> doc/guides/prog_guide/rte_flow.rst:6
> doc/guides/sample_app_ug/kernel_nic_interface.rst:4
> doc/guides/sample_app_ug/link_status_intr.rst:1
> drivers/event/dpaa2/dpaa2_eventdev.c:2
> drivers/event/octeontx/ssovf_evdev.c:2
> drivers/event/skeleton/skeleton_eventdev.c:2
> drivers/event/skeleton/skeleton_eventdev.h:1
> drivers/event/sw/sw_evdev.c:2
> drivers/event/sw/sw_evdev_xstats.c:1
> drivers/net/bonding/rte_eth_bond_pmd.c:1
> drivers/net/i40e/i40e_ethdev.c:1
> examples/ethtool/lib/rte_ethtool.c:21
> examples/ethtool/lib/rte_ethtool.h:21
> examples/eventdev_pipeline_sw_pmd/main.c:6
> examples/ipsec-secgw/ipsec-secgw.c:2
> examples/l2fwd-jobstats/main.c:1
> examples/quota_watermark/qw/init.c:2
> examples/quota_watermark/qw/init.h:2
> examples/quota_watermark/qw/main.c:1
> examples/server_node_efd/node/node.c:2
> examples/tep_termination/vxlan_setup.c:1
> examples/tep_termination/vxlan_setup.h:2
> lib/librte_eventdev/rte_event_eth_rx_adapter.c:1
> lib/librte_eventdev/rte_eventdev.c:7
> lib/librte_eventdev/rte_eventdev.h:11
> lib/librte_eventdev/rte_eventdev_pmd.h:2
> test/test/test_link_bonding.c:1
> test/test/test_link_bonding_mode4.c:2
> test/test/test_link_bonding_rssconf.c:3
> 



More information about the dev mailing list